fix: Use DbConnection instead of custom Client for browser template#4167
Closed
cloutiertyler wants to merge 2 commits intomasterfrom
Closed
fix: Use DbConnection instead of custom Client for browser template#4167cloutiertyler wants to merge 2 commits intomasterfrom
cloutiertyler wants to merge 2 commits intomasterfrom
Conversation
Remove the custom Client class that used JSON protocol and HTTP for reducer calls. Instead, use the standard DbConnection with code generation, which uses BSATN binary protocol over WebSocket. The browser-ts template now: - Uses spacetime generate for TypeScript bindings - Bundles bindings with vite into an IIFE - Loads the bundle in index.html with inline JavaScript
2 tasks
Contributor
Author
|
Closing in favor of #4161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the browser-ts template to use the standard
DbConnectionpattern instead of a customClientclass.Changes:
Clientclass that used JSON WebSocket protocol and HTTP for reducer callsspacetime generateand the generatedDbConnectionclass with BSATN binary protocolDbConnectiongloballyindex.htmlto load the bundle and use inline JavaScriptWhy this matters:
Test plan
spacetime dev --template browser-ts test-appnpm install && npm run buildin the created projectindex.htmlin a browser and verify connection works