fix(ui): Prevent infinite loading spinner on factor-two without active 2FA by alexcarpenter · Pull Request #7751 · clerk/javascript

alexcarpenter · 2026-02-03T21:13:15Z

Description

Fixes an issue where users landing on the factor-two sign-in route without an active 2FA session would see an infinite loading spinner. This can occur when navigating directly to the URL with a force redirect parameter. The fix adds a status check to redirect users back to the sign-in start page if the sign-in status is not 'needs_second_factor', matching the existing pattern in SignInFactorOne.

Test Plan

✅ Added test case for navigation when sign-in status is invalid
✅ All 29 existing SignInFactorTwo tests pass
✅ Test fails without the fix (confirms bug), passes with the fix (confirms fix works)

Type of change

🐛 Bug fix

Summary by CodeRabbit

Bug Fixes

Fixed an infinite loading spinner that appeared when accessing the two-factor sign-in page without an active 2FA session. Users are now properly redirected to the main sign-in page in this scenario.

…e 2FA session When users land on the factor-two sign-in route without an active 2FA session (e.g., via a force redirect URL), they would get stuck on an infinite loading spinner. This fix adds a status check to redirect users back to the sign-in start page if the sign-in status is not 'needs_second_factor', matching the pattern already implemented in SignInFactorOne. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

vercel · 2026-02-03T21:13:20Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	Feb 3, 2026 9:16pm

changeset-bot · 2026-02-03T21:13:24Z

🦋 Changeset detected

Latest commit: 9942e36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-02-03T21:15:53Z

📝 Walkthrough

Walkthrough

This change fixes an infinite loading spinner issue in the SignInFactorTwo component. The fix adds a redirect mechanism that navigates users back to the sign-in start route when they access the factor-two sign-in page without an active second-factor authentication session. A React effect monitors the sign-in status and router to trigger the redirect when the status is not 'needs_second_factor'. A changeset entry documents this patch release, and a new test replaces a placeholder to verify the navigation behavior occurs as expected.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(ui): Prevent infinite loading spinner on factor-two without active 2FA' accurately and specifically summarizes the main bug fix in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-02-03T21:19:37Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7751

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7751

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7751

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7751

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7751

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7751

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7751

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7751

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7751

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7751

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7751

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7751

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7751

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7751

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7751

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7751

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7751

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7751

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7751

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7751

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7751

commit: 9942e36

Ephem · 2026-02-05T08:57:40Z

packages/ui/src/components/SignIn/SignInFactorTwo.tsx

+    if (signIn.status !== 'needs_second_factor') {
+      void router.navigate('../');
+    }


Could we detect if the user is signed in and redirect to any present redirect url in that case? 🤔

alexcarpenter · 2026-02-05T17:19:59Z

closing in favor of #7774

github-actions bot added the core-3 label Feb 3, 2026

vercel bot deployed to Preview February 3, 2026 21:14 View deployment

chore: add changeset

9942e36

vercel bot deployed to Preview February 3, 2026 21:16 View deployment

alexcarpenter changed the title ~~fix(ui): prevent infinite loading spinner on factor-two without active 2FA~~ fix(ui): Prevent infinite loading spinner on factor-two without active 2FA Feb 3, 2026

wobsoriano approved these changes Feb 3, 2026

View reviewed changes

octoper approved these changes Feb 3, 2026

View reviewed changes

Ephem reviewed Feb 5, 2026

View reviewed changes

alexcarpenter closed this Feb 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): Prevent infinite loading spinner on factor-two without active 2FA#7751

fix(ui): Prevent infinite loading spinner on factor-two without active 2FA#7751
alexcarpenter wants to merge 2 commits intomainfrom
alexcarpenter/fix-signin-spinner

alexcarpenter commented Feb 3, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 3, 2026 •

edited

Loading

Walkthrough

Uh oh!

pkg-pr-new bot commented Feb 3, 2026

Uh oh!

Ephem Feb 5, 2026

Uh oh!

alexcarpenter commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alexcarpenter commented Feb 3, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Plan

Type of change

Summary by CodeRabbit

Bug Fixes

Uh oh!

vercel bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

pkg-pr-new bot commented Feb 3, 2026

Uh oh!

Ephem Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

alexcarpenter commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alexcarpenter commented Feb 3, 2026 •

edited by coderabbitai bot

Loading

vercel bot commented Feb 3, 2026 •

edited

Loading

changeset-bot bot commented Feb 3, 2026 •

edited

Loading

coderabbitai bot commented Feb 3, 2026 •

edited

Loading