fix(debugger): use Node.js script on Windows to forward stdin properly #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, batch files (.cmd) do not forward stdin to child processes. This breaks tools like ckb-testtool that pass transaction data via stdin using spawnSync with the input option. Replace the Windows batch file with a Node.js script that uses spawn with stdio: 'inherit' to properly forward stdin, stdout, and stderr.
Now that Windows supports stdin forwarding via the Node.js wrapper, we can enable mock tests on Windows by commenting out the setWasmDebuggerEnabled(true) line in generated test files. Changes: - Detect Windows platform early in create-test.sh - Post-process mock.test files on Windows to comment out WASM mode - Remove Windows test skip logic (now runs all tests on all platforms) This allows GitHub Actions Windows CI to test the stdin forwarding fix.
On Windows, npm global installs create .cmd files that require shell execution. Change the Node.js wrapper to use shell: isWindows so that spawn can properly find and execute offckb.cmd via cmd.exe. This fixes the build failure in CI: Failed to start offckb: spawn offckb ENOENT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, batch files (.cmd) do not forward stdin to child processes. This breaks tools like ckb-testtool that pass transaction data via stdin using spawnSync with the input option.
Replace the Windows batch file with a Node.js script that uses spawn with stdio: 'inherit' to properly forward stdin, stdout, and stderr.