Skip to content

Conversation

@dbatten5
Copy link

@dbatten5 dbatten5 commented Apr 22, 2023

  • ignore files that don't need tests, e.g. files in docs/ and .md files

closes #1328

- ignore files that don't need tests, e.g. files in `docs/` and `.md`
  files
Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@chaos-baum chaos-baum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever!

@bosd
Copy link

bosd commented Feb 27, 2024

@cjolowicz Can you please have a look at this? and merge 🙏

@webknjaz
Copy link

This will cause problems with branch projection rules since the expected checks will stop showing up for docs-only changes. This can be solved by having a job that determines what other jobs should run. It's done in python/cpython, pypa/pip, ansible/pylibssh to give a few examples of reference implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore the tests github action workflow if not necessary

4 participants