-
Notifications
You must be signed in to change notification settings - Fork 507
mbedtls files changed and cmake instruction added to support MbedTLS … #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
mbedtls files changed and cmake instruction added to support MbedTLS … #782
Conversation
6734add to
73b0627
Compare
This helps windows libraries get installed to ``` bin\srtp2.dll lib\srtp2.lib ``` This is the split we use at conda-forge to help keep the dlls findable while keeking the lib files separate. Let me know if you have any concerns. Excited to see this upstreamed.
1c89e10 to
1791e08
Compare
…V4.0 Signed-off-by: Sayed Naser Moravej <seyednasermoravej@gmail.com>
1791e08 to
40c43bf
Compare
|
How can I check CI before push my code? |
|
I normally just try to replicate the environment, or else do a lot of pushing to a PR and then clean up and squash before creating the final PR. Just looking quickly I would guess you need to update the CI scripts to use MbedTLS 4 or ? |
I tested this scripts on Ubuntu 24.04 and Ubuntu 22.04. Maybe you face python errors because of absence of some packages. Please install them via pip. If you face no python error, you could create a .sh file and source it:
|
Hi Cisco team, and Merry Christmas 🎄
This PR is a draft for the migration to Mbed TLS v4.0.
For easier review and comparison, I’ve kept both the legacy code and the new implementation side by side.
There are still some unnecessary fields in a few structures, and in some places the implementation can be improved (for example, using
statusinstead oferrCode). I intentionally kept the changes as minimal as possible for now; we can clean up and refine these parts in follow-up steps once the migration direction is agreed upon.Feedback and suggestions are very welcome.