Add player controller to make ASC process inputs#4
Open
MostExcellent wants to merge 6 commits intochronicler-software:mainfrom
Open
Add player controller to make ASC process inputs#4MostExcellent wants to merge 6 commits intochronicler-software:mainfrom
MostExcellent wants to merge 6 commits intochronicler-software:mainfrom
Conversation
… its input processing function
cybtachyon
reviewed
Nov 19, 2025
| class UModularAbilitySystemComponent; | ||
|
|
||
| UCLASS(Config = "Game") | ||
| class MODULARGAMEPLAYABILITIES_API AModularAbilityPlayerController : public AModularPlayerController |
Contributor
There was a problem hiding this comment.
Would it be better to inherit from ACommonPlayerController?
Author
There was a problem hiding this comment.
Done, it now inherits from ACommonPlayerController. Should it also send out the game framework extension events?
Author
There was a problem hiding this comment.
Actually forgot to edit the build.cs file, will do now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for the ModularAbilitySystemComponent to process ability inputs.
I left off some logging from my own project as I was unsure if it was warranted.