Fix DMOD_ENABLE_REGISTRATION multiple definition linker errors #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncommenting
DMOD_ENABLE_REGISTRATIONinmain.ccaused multiple definition linker errors. The root cause:dmlist.cunconditionally definedDMOD_ENABLE_REGISTRATION, creating duplicate registration structs whenmain.calso defined it before includingdmlist.h.Changes
lib/dmlist/src/dmlist.c: Apply same guard pattern asdmod_system.c:lib/CMakeLists.txt: PassDMOD_EXTERNAL_REGISTRATIONcompile definition to dmlist target when enabledsrc/main.c: UncommentDMOD_ENABLE_REGISTRATIONto enable the featureNote
The dmlist submodule commit needs to be pushed upstream to
choco-technologies/dmlistbefore CI will pass.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.