Skip to content

Refactor deprecated code for FishnetV4 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwan3854 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

Refactor deprecated code for FishnetV4 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Assets/NetworkParticleSystem/Scripts/NetworkParticleSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ private struct ParticleSyncData
private List<Vector4> _customData = new List<Vector4>();
public List<Vector4> CustomData => _customData;

[SyncVar(OnChange = nameof(OnSyncDataChanged))]
private ParticleSyncData _psSyncData;
private readonly SyncVar<ParticleSyncData> _psSyncData = new();
private void OnSyncDataChanged(ParticleSyncData prev, ParticleSyncData cur, bool asServer)
{
if (asServer || IsHost) return;
Expand Down Expand Up @@ -103,6 +102,13 @@ private void OnSyncDataChanged(ParticleSyncData prev, ParticleSyncData cur, bool
private void Awake()
{
_particles = new Particle[_particleSystem.main.maxParticles];

_psSyncData.OnChange += OnSyncDataChanged;
}

private void OnDestroy()
{
_psSyncData.OnChange -= OnSyncDataChanged;
}

public override void OnStartNetwork()
Expand Down Expand Up @@ -207,7 +213,7 @@ public override void OnSpawnServer(NetworkConnection connection)

if (_syncSeed)
{
_psSyncData = new ParticleSyncData()
_psSyncData.Value = new ParticleSyncData
{
Seed = _particleSystem.randomSeed,
Time = _particleSystem.time,
Expand Down