fix(collector): add index label to hwmon metrics to distinguish devices #456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455
Description
Some hwmon devices can report the exact same name.
Previously, the collector relied solely on this name for labelling. In my case, this caused Prometheus to treat metrics from different sockets as duplicates, resulting in silent data loss (one socket overwriting the other).
The Fix:
This PR adds a unique index label (derived from the directory number, e.g., 6 or 7) to the generated metrics. This ensures every socket produces a unique time series, even if they share the same driver name.
How Has This Been Tested?
Tested on a dual-socket AMD EPYC server running Rocky Linux 9.
Before:
Output showed only one metric series for
amd_hsmp_hwmondespite two sockets being present.After:
Output now correctly shows two distinct series with unique indices: