Add shared example tests for valid and invalid assertion and attestation responses #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolastemciuc
requested review from
joaquintomas2003 and
santiagorodriguez96
Comment on lines
42
to
51
| expect { | ||
| assertion_response.verify( | ||
| challenge, | ||
| public_key: public_key, | ||
| sign_count: sign_count, | ||
| user_presence: user_presence, | ||
| user_verification: user_verification, | ||
| rp_id: rp_id | ||
| ) | ||
| }.not_to raise_error |
Contributor
There was a problem hiding this comment.
Why did we had to change it from expect { ... }.to be_truthy to expect { ... }..not_to raise_error?
Member
Author
There was a problem hiding this comment.
Good catch, it wasn't necessary. Fixed in a4bb0ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.