Mostrar materias habilitadas del semestre actual en lugar de materias del INCO #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolastemciuc
force-pushed
the
nt--scrape-current-subjects
branch
4 times, most recently
from
c9f8a47 to
b74d077
Compare
nicolastemciuc
changed the title
nicolastemciuc
changed the title
nicolastemciuc
force-pushed
the
nt--scrape-current-subjects
branch
from
b74d077 to
364102d
Compare
nicolastemciuc
force-pushed
the
nt--scrape-current-subjects
branch
from
b3da0f8 to
207be9c
Compare
nicolastemciuc
changed the title
nicolastemciuc
requested review from
EmilioCristalli,
RenzoMinelli,
joaquintomas2003 and
santiagorodriguez96
...te/20250731134828_rename_current_optional_subject_to_current_semester_subject_in_subjects.rb
Outdated
Show resolved
Hide resolved
...0250731131318_rename_include_inco_subjects_to_include_current_semester_subjects_in_degree.rb
Outdated
Show resolved
Hide resolved
nicolastemciuc
force-pushed
the
nt--scrape-current-subjects
branch
from
748522e to
7ed1055
Compare
...te/20250731134828_rename_current_optional_subject_to_current_semester_subject_in_subjects.rb
Outdated
Show resolved
Hide resolved
RenzoMinelli
reviewed
Aug 4, 2025
app/models/subject.rb
Outdated
| # category :string default("optional") | ||
| # code :string | ||
| # credits :integer not null | ||
| # current_semester :boolean default(FALSE) |
Collaborator
There was a problem hiding this comment.
viendo ahora esto, veo que no tenemos el not null para la columna. Deberiamos?
RenzoMinelli
reviewed
Aug 4, 2025
RenzoMinelli
previously approved these changes
Aug 26, 2025
RenzoMinelli
dismissed
their stale review
Saco el approval porque como hablamos en DM estas materias son las que tienen un periodo de inscripción activo
Member
Author
Ahora se scrapea teniendo en cuenta el periodo de estas materias (haya vencido o no el periodo de inscripción). Por ejemplo para ADADR se entra a la pagina y se chequea que el periodo sea 
|
Member
Author
|
Teniendo en cuenta que es independiente del scrapeo de materias, me pregunto si se debería correr separadamente, incluso la logica podría ir en otro archivo 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Este PR reemplaza la logica de las materias del INCO del semestre actual por mostrar todas las materias habilitadas de el semestre actual.
subjectsydegreespara que sean mas genericos.Por qué?