Skip to content

Run Rubocop as part of a different job #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolastemciuc merged 2 commits into from
Feb 21, 2025
Merged

Run Rubocop as part of a different job #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1639034
build(deps): bump `rubocop` constrain from `0.80.1` to `~> 1`
nicolastemciuc Feb 18, 2025
b170869
ci: run `rubocop` in a different job
nicolastemciuc Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,21 @@ name: build
on: push

jobs:
lint:
runs-on: ubuntu-latest

steps:
- name: Check out repository code
uses: actions/checkout@v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.4'
bundler-cache: true

- name: Lint code for consistent style
run: bundle exec rubocop -f github
Comment on lines +13 to +27
Copy link
Contributor

@santiagorodriguez96 santiagorodriguez96 Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it's supposed that new cops are not enabled by default when introduced between major versions, I'm a little worried about the CI suddenly starting to fail as rubocop keeps releasing new versions – perhaps we could open up a separate PR to start tracking the Gemfile.lock again to ensure that we always get the same version?

Copy link
Member Author

@nicolastemciuc nicolastemciuc Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we could do that!

The Gemfile.lock only needs to support the latest Ruby version, right? We don't have to worry about EOL Ruby versions, do we?

Copy link
Contributor

@santiagorodriguez96 santiagorodriguez96 Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly!

test:
runs-on: ubuntu-20.04
strategy:
Expand Down Expand Up @@ -62,4 +77,4 @@ jobs:
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- run: bundle exec rake
- run: bundle exec rspec
2 changes: 1 addition & 1 deletion cose.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "byebug", "~> 11.0"
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "rspec", "~> 3.8"
spec.add_development_dependency "rubocop", "0.80.1"
spec.add_development_dependency "rubocop", "~> 1"
spec.add_development_dependency "rubocop-performance", "~> 1.4"
end
Loading