chore: improve development workflow #103
Conversation
jbroma
left a comment
There was a problem hiding this comment.
Hey, thanks for the contribution 🎉
most changes look good, left few comments tho 👍
package.json
Outdated
| "lint": "biome check --write", | ||
| "typecheck": "pnpm -r typecheck" | ||
| "typecheck": "pnpm -r typecheck", | ||
| "lint-staged": "lint-staged" |
There was a problem hiding this comment.
not needed, in husky you can just run pnpm lint-staged
package.json
Outdated
| "lint-staged": "^16.2.7" | ||
| }, | ||
| "lint-staged": { | ||
| "*.{ts,tsx,js,jsx,json,md}": "biome format" |
There was a problem hiding this comment.
I'd rather go with lint which will run everything it can (lint,format,import organizer)
|
Hey @jbroma, thanks for the review! |
jbroma
left a comment
There was a problem hiding this comment.
it seems that there is still no setup for husky and running lint-staged (which was removed) - lets bring it back and setup husky, I believe it was pnpx husky init to create the precommit hook :)
|
Hi @jbroma, any update on this? |
jbroma
left a comment
There was a problem hiding this comment.
sorry for the delay, I was on sick leave, everything looks good, found just these 2 things:
Co-authored-by: Jakub Romańczyk <lorczyslav@gmail.com>
Co-authored-by: Jakub Romańczyk <lorczyslav@gmail.com>
|
Sorry to hear that, I hope you're good now. |
|
@azizbecha please resolve the conflicts and then we can merge this 🚀 |

Summary
This PR significantly improves the development workflow by implementing automated code quality and commit validation. It introduces:
1. Git Hooks (Husky)
2. Automated Code Formatting (Lint-Staged)
3. Commit Message Validation (Commitlint)
4. Enhanced npm Scripts
pnpm run build:all- Builds all packages in correct dependency orderpnpm run dev- Starts the tester dev serverpnpm run preview- Previews the production buildTest plan
Test pre-commit hook:
Test commit message validation:
Verify all scripts work: