fix: update glob to v10.5.0 to resolve CVE-2025-64756#910
Merged
satya164 merged 5 commits intocallstack:mainfrom Nov 24, 2025
Merged
fix: update glob to v10.5.0 to resolve CVE-2025-64756#910satya164 merged 5 commits intocallstack:mainfrom
satya164 merged 5 commits intocallstack:mainfrom
Conversation
satya164
requested changes
Nov 22, 2025
Member
satya164
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Please remove glob from resolutions. Overriding package version for monorepo only means we are not testing with the same set of dependencies that users may get. So the dependency tree could still contain vulnerable versions of glob while the monorepo doesn't show this, or result in different behavior from what users will install.
Contributor
Author
|
Fixed in the latest commit. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
globpackage to version^10.5.0to resolve the command injection vulnerability CVE-2025-64756.Changes included:
globdependency inpackages/react-native-builder-bobfrom^8.0.3to^10.5.0.src/utils/compile.tsto use the newglobSyncnamed export fromglobv10 API.@types/globfromdevDependenciesasglobv10 includes built-in type definitions, and the old types caused conflicts.resolutionin the rootpackage.jsonto forceglob@^10.5.0across the monorepo, ensuring no vulnerable versions remain in the lockfile.Test plan
yarn testinpackages/react-native-builder-bob. All tests passed.yarn workspace react-native-builder-bob testyarn typecheckto verify that removing@types/globand using built-in types works correctly.yarn lintto ensure no linting errors.Note
Updates
globto ^10.5.0, refactors to useglobSync, and removes@types/globnow that types are bundled.globinpackages/react-native-builder-bob/package.jsonfrom^8.0.3to^10.5.0.@types/globfromdevDependencies(types included inglobv10).packages/react-native-builder-bob/src/utils/compile.tsto import{ globSync }fromgloband replaceglob.synccall.yarn.lockto reflectglob@10.5.0and updated transitive dependencies.Written by Cursor Bugbot for commit 1f1c339. This will update automatically on new commits. Configure here.