wit-parser: Add validation hooks for custom linting
#2419
+392
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2418
There are two strategies I've explored for giving consumers access to source locations:
Make spans available on resolved items so consumers can inspect them after resolution. There are two ways I found to do this
span: Option<Span>directly toTypeDef,Function,Interface,WorldHashMap<Id, Span>fields onResolveResolvederivesDefaultso not likely to break consumers)Hook into internal validation (this PR)
Keep spans private but let consumers hook into the resolution process via a
Validatortrait with callbacks.push_*calls, not after-the-fact inspectionThis PR implements Strategy 2 because it avoids breaking changes and has zero cost for existing. However, I'm happy to go with one of the other strategies or something totally new that I haven't considered.
Here's an example of how a consumer would use this new features: