[wasm-metadata] rename Author to Authors#2052
Merged
alexcrichton merged 4 commits intobytecodealliance:mainfrom Feb 13, 2025
Merged
[wasm-metadata] rename Author to Authors#2052alexcrichton merged 4 commits intobytecodealliance:mainfrom
Author to Authors#2052alexcrichton merged 4 commits intobytecodealliance:mainfrom
Conversation
Member
Author
|
oops, hold on - submodule issues. Let me fix that. |
lann
approved these changes
Feb 13, 2025
Contributor
lann
left a comment
lann
left a comment
There was a problem hiding this comment.
I find it annoying that it is specified as plural but no guidance is given as to how to actually encode multiple authors. 🙄
Not our fault though so lgtm.
alexcrichton
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While filing bytecodealliance/wasm-pkg-tools#150 I realized the OCI annotation is called
org.opencontainers.image.authors. While inwasm-metadatawe called itAuthor. The lack of pluralization was unintentional from my part, and this PR fixes that. Thanks!cc/ @bytecodealliance/sig-packaging