This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Updating for wit-bindgen refactoring #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dicej there are failures here I'm going to need your help investigating in the future, I'll ping you about that on Monday |
alexcrichton
force-pushed
the
wit-bindgen-refactoring
branch
from
54fb3a2 to
ce4164e
Compare
alexcrichton
commented
Mar 28, 2025
crates/test-programs/src/bin/sockets_0_3_tcp_sample_application.rs
Outdated
Show resolved
Hide resolved
Member
Author
There was a problem hiding this comment.
@dicej you should double-check me in this file, I just went all hack-and-slash to things and wasn't very discerning.
Member
Author
|
Upstream PRs this one references: |
dicej
approved these changes
Mar 31, 2025
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
LGTM. I haven't studied the wit-bindgen PR closely yet, but the way the new APIs are used in the tests looks reasonable.
crates/wasmtime/src/runtime/component/concurrent/futures_and_streams.rs
Outdated
Show resolved
Hide resolved
Member
Author
|
Ok I'm going to queue this up for merge after addressing major work items here. @rvolosatovs I'll work on updating #58 after this merges |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of things in flight and I'm rapidly losing steam today. I wanted to open this up to make other folks aware this is coming though. Sorry I don't have the time/energy right now to flesh out the description more. I'll do that on Monday.