You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @ricochet thanks for the contribution! So the implementation looks fantastic so far -- broken tests aside (it looks like there's a small use-before-definition, probably an easy fix).
That said, I think that we might be better served by using the functionality already present in jco's build of wasm-tools (there's a bit of a co-dependent situation at play here which might be surprising.
This is actually already supported (see the form of producers-fields), so I think you should be able to achieve what you wanted by just including the relevant fields in the metadataAdd call.
That should be the last argument to the metadataAdd function. With that change and an update to the tests to use the API and the CLI (an "E2E" test with package.json filled out as you'd want), I think we'd be good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301