Fix memory leak in call() retptr allocation#295
Merged
tschneidereit merged 1 commit intobytecodealliance:mainfrom Sep 16, 2025
Merged
Fix memory leak in call() retptr allocation#295tschneidereit merged 1 commit intobytecodealliance:mainfrom
tschneidereit merged 1 commit intobytecodealliance:mainfrom
Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Contributor
|
Thanks for this @ludfjig ! @tschneidereit would you mind taking a look at this? |
tschneidereit
approved these changes
Sep 16, 2025
Member
tschneidereit
left a comment
There was a problem hiding this comment.
Yeah, that's definitely the right thing to do—thank you for tracking this down!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript components leak memory when returning non-primitive types (strings, objects, arrays, etc.).
Cause
Return pointer allocation used
JS_reallocwhich bypasses memory tracking, so allocations were never freed.Fix
Use
cabi_reallocinstead to ensure proper tracking and cleanup.Before:
RES memory leaks indefinitely as can be seen in repro provided in #279:
After:
RES memory stabilizes after X guest call iterations:
Closes #279