Skip to content

Add Progress Bars, parameter comment formatting, removed duplicate processing items#19

Open
Average-Bear wants to merge 8 commits intobwya77:masterfrom
Average-Bear:master
Open

Add Progress Bars, parameter comment formatting, removed duplicate processing items#19
Average-Bear wants to merge 8 commits intobwya77:masterfrom
Average-Bear:master

Conversation

@Average-Bear
Copy link
Contributor

@Average-Bear Average-Bear commented Dec 5, 2018

**After submitting the request, I've made more changes that end up flowing in as more commits to my own branch. So, here are the additional items below:

  • Added progress bars to each main foreach loop
  • Generated a new $Total variable count before every foreach loop
  • Slightly changed parameter formatting with comments directly above their intended parameter/code
  • Added checking all Domain Controllers for user data to ensure accuracy of LastLogon time, as LastLogon does not replicate over Domain Controllers and will be solely dependent on which one you're querying
  • Removed multiple instances of Get-ADComputer and search local variable ($Computers) after data is gathered.

Added #Requires for version and module requirements associated with this script.
Removed duplicate Get-ADComputer function and moved the remaining instance to line 245; it is now filtered for information with the local data already retrieved.
@Average-Bear Average-Bear changed the title Update Progress bars Add Progress Bars, parameter comment formatting, removed duplicate processing items Dec 6, 2018
@bwya77
Copy link
Owner

bwya77 commented Dec 8, 2018

Im running into some errors on this one, I am taking a look a little deeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants