Skip to content

Fix the release parameter used in docker save #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkwarren merged 2 commits into from
Feb 18, 2026
Merged

Fix the release parameter used in docker save #2270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f91d3a
Fix the release parameter used in docker save
pkwarren Feb 18, 2026
61ac315
Lint fix
pkwarren Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions internal/cmd/release/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ func (c *command) calculateNewReleasePlugins(ctx context.Context, currentRelease
// Found existing release - only rebuild if changed image digest or buf.plugin.yaml digest
if pluginRelease.ImageID != imageID || pluginRelease.PluginYAMLDigest != pluginYamlDigest {
downloadURL := c.pluginDownloadURL(plugin, releaseName)
zipDigest, err := createPluginZip(ctx, c.logger, tmpDir, plugin, registryImage, imageID)
zipDigest, err := createPluginZip(ctx, c.logger, tmpDir, plugin, registryImage)
if err != nil {
return err
}
Expand Down Expand Up @@ -438,7 +438,6 @@ func createPluginZip(
basedir string,
plugin *plugin.Plugin,
registryImage string,
imageID string,
) (string, error) {
if err := pullImage(ctx, logger, registryImage); err != nil {
return "", err
Expand All @@ -453,7 +452,7 @@ func createPluginZip(
logger.WarnContext(ctx, "failed to remove tmp dir", slog.String("dir", pluginTempDir), slog.Any("error", err))
}
}()
if err := saveImageToDir(ctx, imageID, pluginTempDir); err != nil {
if err := saveImageToDir(ctx, registryImage, pluginTempDir); err != nil {
return "", err
}
logger.InfoContext(ctx, "creating zip", slog.String("name", zipName))
Expand Down