Convert fetcher command to buf.build/go/app#2263
Merged
Conversation
Migrate the fetcher command to use the buf.build/go/app.
pkwarren
force-pushed
the
pkw/fetcher-bufapp
branch
from
a236830 to
c84694a
Compare
stefanvanburen
approved these changes
Feb 17, 2026
Member
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
lgtm; thanks for doing the slog migration too. I think we can probably nix the interrupt handling here
| appContainer := app.NewContainer(map[string]string{}, os.Stdin, os.Stdout, os.Stderr, root) | ||
| nameContainer, err := appext.NewNameContainer(appContainer, "fetcher") | ||
| require.NoError(t, err) | ||
| logger := slog.New(slog.NewTextHandler(testWriter{t}, &slog.HandlerOptions{Level: slog.LevelDebug})) |
Member
There was a problem hiding this comment.
I thought we had something like this upstream, but I'm not seeing it. feels like something we ought to have (maybe in standard-go? vaguely related: bufbuild/standard-go#4)
Member
Author
There was a problem hiding this comment.
It would definitely be handy - especially now that t.Output exists.
stefanvanburen
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the fetcher command to use the buf.build/go/app.