Add LSP diagnostic when compilation fails#4318
Merged
stefanvanburen merged 2 commits intomainfrom Feb 4, 2026
Merged
Conversation
Noticed that we weren't generating diagnostics for an import of a non-existent file, which made it confusing when the file looked fine otherwise. Also, fixes the diagnostic to use proper .Start() and .End() for the diagnostic range, instead of a zero-width range consisting of only the start. (I might be missing something here, but worked for me; this was seemingly added way back in bufbuild/protocompile#205.)
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Member
Author
|
Looks like: 
|
emcfarlane
approved these changes
Feb 4, 2026
This might be misusing the reporter APIs, but just so we aren't missing a diagnostic, assume we can have one coming back in the error _and_ some from the reporter.
emcfarlane
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that we weren't generating diagnostics for an import of a non-existent file, which made it confusing when the file looked fine otherwise.
Also, fixes the diagnostic to use proper .Start() and .End() for the diagnostic range, instead of a zero-width range consisting of only the start. (I might be missing something here, but worked for me; this was seemingly added way back in bufbuild/protocompile#205.)