Move testing dependencies to devDependencies#54
Open
gpittarelli wants to merge 1 commit intobrowserstack:masterfrom
Open
Move testing dependencies to devDependencies#54gpittarelli wants to merge 1 commit intobrowserstack:masterfrom
gpittarelli wants to merge 1 commit intobrowserstack:masterfrom
Conversation
gpittarelli
force-pushed
the
gjp/package-json-cleanup
branch
from
6b98eb4 to
846a99a
Compare
gpittarelli
force-pushed
the
gjp/package-json-cleanup
branch
from
846a99a to
94c1202
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sinonandtemp-fsare only used in test code; so they should be indevDependenciesto make installs of this module a bit lighter.Particularly annoying since this version of sinon pulls in an old version of the util library... which seems to take precedence over the builtin
utilmodule in some situations 😖Travis failure seems to be due to a missing
BROWSERSTACK_ACCESS_KEY; providing one getsnpm testto pass for me.