Use identical modified-deleted timestamps in dailyroutine #803
+2
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases there might be an offset of 1sec. However it should have the same behavior as when deleting a beneficiary through the UI
HaGuesto
reviewed
Jan 21, 2026
| WHERE p2.parent_id = p1.id AND p1.deleted AND (NOT p2.deleted OR p2.deleted IS NULL)'); | ||
| while ($row = db_fetch($result)) { | ||
| db_query('UPDATE people SET deleted = NOW() WHERE id = :id', ['id' => $row['id']]); | ||
| db_query('UPDATE people SET deleted = NOW(), modified = NOW(), modified_by = :user WHERE id = :id', ['user' => $_SESSION['user']['id'], 'id' => $row['id']]); |
Member
There was a problem hiding this comment.
@pylipp could we change it that the now timestamp matches the now timestamp in the history message?
HaGuesto
reviewed
Jan 21, 2026
|
|
||
| if ($row['diff'] > $row['treshold']) { | ||
| db_query('UPDATE people SET deleted = NOW() WHERE id = :id', ['id' => $row['id']]); | ||
| db_query('UPDATE people SET deleted = NOW(), modified = NOW(), modified_by = :user WHERE id = :id', ['user' => $_SESSION['user']['id'], 'id' => $row['id']]); |
Member
There was a problem hiding this comment.
@pylipp could we change it that the now timestamp matches the now timestamp in the history message?
HaGuesto
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/8dcyW5aQ