Open
Conversation
(setting env variables with the env parameter)
ZedThree
requested changes
Jan 21, 2026
Comment on lines
+55
to
+57
| if result.stderr: | ||
| output += "\nSTDERR:\n" + result.stderr | ||
| return result.returncode, output |
Member
There was a problem hiding this comment.
Let's just switch to an f-string here:
Suggested change
| if result.stderr: | |
| output += "\nSTDERR:\n" + result.stderr | |
| return result.returncode, output | |
| if result.stderr: | |
| output = f"{output}\nSTDERR:\n{result.stderr}" | |
| return result.returncode, output |
| else: | ||
| cmd = f"OMP_NUM_THREADS={mthread} {cmd}" | ||
| # Set OMP_NUM_THREADS if mthread is provided (for OpenMP in BOUT++) | ||
| env = dict(os.environ) |
Member
There was a problem hiding this comment.
Isn't os.environ already a dict? Or is this just to make a copy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use subprocess.run() instead of subprocess.Popen(),
setting environment variables set with the env parameter.
This change is required in order for tests to by run in parallel via pytest and xdist.