Fix CI CMake formatting.

[oparry-ukaea]

Add a missing in-place flag such that the CI CMake formatting step works as intended.

[oparry-ukaea]

Ah - guess I need to exclude externalpackages?

[dschwoerer]

Ah - guess I need to exclude externalpackages?

I do not think so. The cmake code for PVODE was done by @ZedThree

[oparry-ukaea]

ok. I assume it will also modify externalpackages/fmt/CMakeLists.txt etc, but submodule changes don't get added.

[dschwoerer]

I do not think they are checked out - and thus not modified.

[oparry-ukaea]

Please feel free to merge if you're happy

[ZedThree]

I'm definitely in favour of automatting the formatting, but please can we tweak the config before merging this? Currently it formats bout_add_example very badly:

bout_add_example(
  conduction-snb
  SOURCES
  conduction-snb.cxx
  EXTRA_FILES
  fit_temperature.py
  sinusoid.py
  snb.csv
  spitzer-harm.csv
  step.py
  temperature.csv
  vfp.csv
  DATA_DIRS
  data
  step)

It looks like there's support for custom commands that should make this nicer.

I also see there's a "dangle_parens" option that would be good to enable. This puts the closing bracket on a newline for multiline commands, which helps keep diffs small.

[dschwoerer]

Looks good. Maybe you can rebase to remove the bot commits + force push? Then we do not have the bad formatting in the history.

[ZedThree]

There's some missing kwargs for the custom commands (you probably want to double check this config works though!)

[oparry-ukaea]

Looks good. Maybe you can rebase to remove the bot commits + force push? Then we do not have the bad formatting in the history.

Will do - I'll make the changes that Peter suggested, then force push to get rid of the bot commits once we're happy that the templates are correct.

[oparry-ukaea]

Made those template changes and disabled an option that seemed to be screwing up comments.

[ZedThree]

Lovely, thanks @oparry-ukaea!

[oparry-ukaea]

👍 I'll force push once more to get rid of the bot commit.

[oparry-ukaea]

Ready to merge.