Add checks to chooseProcessorSplit function in boutmesh.cxx#3260
Open
wearysebas wants to merge 2 commits intonextfrom
Open
Add checks to chooseProcessorSplit function in boutmesh.cxx#3260wearysebas wants to merge 2 commits intonextfrom
wearysebas wants to merge 2 commits intonextfrom
Conversation
Setting NXPE or NYPE would not trigger the checks of number of points / number of specified processes. Also added tests to it and modified previous tests to work.
dschwoerer
requested changes
Feb 17, 2026
Contributor
dschwoerer
left a comment
dschwoerer
left a comment
There was a problem hiding this comment.
Thank you for adding checks and providing tests 🎉
The tests are failing to compile, as the tests re-use names.
Do you mind fixing that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting NXPE or NYPE would not trigger the checks of number of points / number of specified processes. Also added tests to it and modified previous tests to work.