-
-
Notifications
You must be signed in to change notification settings - Fork 41
Upgrade and unpin python dependencies #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade and unpin python dependencies #921
Conversation
d7fd33a to
75d083d
Compare
|
|
||
| [tool.poetry.group.dev.dependencies] | ||
| pytest = "*" | ||
| bump2version = "^1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about this strategy.
I.e. mypy ^1.0.0 is equivalent to 1.*. Leaving the door open that way can break many things.
And even doing that, you will have to poetry update from time to time.
In other words: I would pin the major versions (as with mypy) and do a poetry update periodically to upgrade the .lock file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you have a lockfile you can't break anything until you execute the poetry update command. The version is already pinned in the lock file. See this as an example.
I would say the purpose of the lockfile is to pin the versions, so I don't see the point of also pin them in the pyproject (unless there is version that really breaks your code and then you can pin in the pyproject until you fix the issue).
Right now, by unpinning them there are no tests failing. This does not mean that there are no bugs but, unless you pin the versions forever you will end up discovering them at some point.
However, feel free to close this PR if you think it's not helping.
|
I'm now having inconsistent buids with For example, some build fail now in my laptop, others in the pipeline, and for different reasons. Forcing poetry update does not seem to fix the issue. |
|
@boriel This is the Ruff version that was used by the CI job: Which one do you have in your laptop?
Maybe this is the root cause of the problem. Probably you don't want to run |
|
Never mind. I recreated my virtualenv and it passed. Weird. |
|
Closing this PR. |
No description provided.