Skip to content

Various fixes to compile with latest GTSAM #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
varunagrawal wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Various fixes to compile with latest GTSAM #397

varunagrawal wants to merge 4 commits into from
+38 −47

Conversation

@varunagrawal
Copy link
Contributor

@varunagrawal varunagrawal commented Jan 8, 2026

  • Use gtsam::NonlinearEquality instead of deprecated gtsam::NonlinearEquality1.
  • Include Ordering.h where applicable.
  • Fix includes.
  • Fix doxygen comments (this is also an issue in GTSAM FYI).

@varunagrawal varunagrawal requested a review from dellaert January 8, 2026 00:04
@varunagrawal varunagrawal self-assigned this Jan 8, 2026
dellaert
dellaert approved these changes Jan 10, 2026
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@dellaert
Copy link
Member

dellaert commented Jan 10, 2026

@havriutkin after this is merged might want to rebase on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@varunagrawal @dellaert