list --format: add fingerprint placeholder #9292
Merged
+81
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9292 +/- ##
==========================================
+ Coverage 75.89% 75.93% +0.03%
==========================================
Files 86 86
Lines 14761 14771 +10
Branches 2198 2199 +1
==========================================
+ Hits 11203 11216 +13
+ Misses 2884 2879 -5
- Partials 674 676 +2 ☔ View full report in Codecov by Sentry. |
This allows users to compare file content efficiently without reading the full file data, by exposing a hash of the chunk IDs and the relevant conditions for valid comparisons, like chunker params, chunker seed/key, id key, key type, etc. This is based on PR borgbackup#5167 by @hrehfeld, code + discussion, with some changes: - the conditions hash now includes more relevant input params - returning a single value that is composed of 2 parts - tests (including new buzhash64) Example output (different files in same archive): 1e88bfb02d0a5320-a539587200c33b857f9827d01fcb7dabacf30501c83929e7308668d43f4a6302 file1 1e88bfb02d0a5320-9ed78a4c14d0506d9ae75d914cca90db64655ddea22647dd1c89f19e2fc080ae file2 The fingerprint has 2 parts: First part: same hash, indicates same chunking / chunk id generation params, meaning that the second part is valid to be compared. Second part: different hash, because file content is different. same hash here would mean same content.
ThomasWaldmann
changed the title
ThomasWaldmann
force-pushed
the
list-fingerprint-master
branch
from
babbbdc to
baed0bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to compare file content efficiently without reading the full file data, by exposing a hash of the chunk IDs and the relevant conditions for valid comparisons, like chunker params, chunker seed/key, id key, key type, etc.
This is based on PR #5167 by @hrehfeld, code + discussion, with some changes:
Example output (different files in same archive):
The fingerprint has 2 parts:
First part: same hash, indicates same chunking / chunk id generation params, meaning that the second part is valid to be compared.
Second part: different hash, because file content is different. same hash here would mean same content.