Fix padme UI #9290
Merged
Fix padme UI #9290
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes borgbackup#9286. Tested manually via: = export BORG_REPO=repo = alias b='python -m borg' = echo meow > file = b create ::test ./file -C obfuscate,250,none = b info Archive name: ::test Archive fingerprint: 2c67ba6c04faa6d911b5dd02b99593ea2cf6ebe7c38e2e6fca90afad47a7095e [...] Command line: /home/user/c/d0/software/backup/borg/src/borg/__main__.py create ::test ./file -C obfuscate,250,none [...] Number of files: 1 Original size: 40 B = rm file = b list ::test -rw-r--r-- user users 5 Mon, 2026-02-09 22:41:54 +0100 file = b extract ::test file = cat file meow = # Yup, all good. Let's go for something nontrivial to make sure it's stripped accordingly. = dd if=/dev/urandom of=file bs=1M count=4 = b create ::test ./file -C obfuscate,250,zstd = mv file original = b info Archive name: ::test Archive fingerprint: 2c67ba6c04faa6d911b5dd02b99593ea2cf6ebe7c38e2e6fca90afad47a7095e [...] Command line: /home/user/c/d0/software/backup/borg/src/borg/__main__.py create ::test ./file -C obfuscate,250,none Working Directory: /home/user/l/bug/borg Number of files: 1 Original size: 40 B Archive name: ::test Archive fingerprint: 01014345dd1187f014f19ac59a2313a4e6d644532b287d806fe87882ca47ea0d [...] Command line: /home/user/c/d0/software/backup/borg/src/borg/__main__.py create ::test ./file -C obfuscate,250,zstd Working Directory: /home/user/l/bug/borg Number of files: 1 Original size: 4.19 MB = b extract aid:01014345dd1187f014f19ac59a2313a4e6d644532b287d806fe87882ca47ea0d = sha256sum file original d74be01406764ef11f5aa3ee27033bdced2c9573c0b3ed980fcfb2116c7d84de file d74be01406764ef11f5aa3ee27033bdced2c9573c0b3ed980fcfb2116c7d84de original =
MultisampledNight
force-pushed
the
fix-padme-ui
branch
from
eeecd94 to
4d494b8
Compare
MultisampledNight
force-pushed
the
fix-padme-ui
branch
from
4d494b8 to
245a468
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9290 +/- ##
==========================================
+ Coverage 75.83% 75.89% +0.05%
==========================================
Files 86 86
Lines 14747 14761 +14
Branches 2194 2198 +4
==========================================
+ Hits 11184 11203 +19
+ Misses 2890 2884 -6
- Partials 673 674 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9286, then include it in tests like the other ones do to make sure this doesn't happen again.
fakeroot toxsucceeded. Backport to1.4-maintincoming as well.(Apologies for taking so long, I got stuck yakshaving by reworking the entire compression spec parsing when I should've just fixed the bug at hand first.)