feat: support multiple GitHub Apps for per-org authentication#163
Open
feat: support multiple GitHub Apps for per-org authentication#163
Conversation
Restructure the github-app config to support multiple labeled blocks, each with its own app-id, private-key, and installation mappings. The TokenManager now routes org lookups to the correct app internally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alecthomas
reviewed
Feb 26, 2026
| orgToApp := map[string]*appState{} | ||
|
|
||
| for _, config := range configs { | ||
| if config.AppID == "" || config.PrivateKeyPath == "" || len(config.Installations) == 0 { |
Collaborator
There was a problem hiding this comment.
Should this be an error?
alecthomas
approved these changes
Feb 26, 2026
|
|
||
| // Config represents the configuration for a single GitHub App. | ||
| type Config struct { | ||
| Name string `hcl:"name,label" help:"Name for this GitHub App configuration."` |
Collaborator
There was a problem hiding this comment.
Do we actually need a name? If we don't need this the config will be completely backwards compatible.
I don't really mind either way.
Collaborator
Author
There was a problem hiding this comment.
We don't in retrospect, initially I thought it would be useful for helping identify the app, but the org is in the map... so it's probably unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github-appconfig from a single block to multiple labeled blocks, each with its own app-id, private-key, and installation mappingsTokenManagernow routes org lookups to the correct GitHub App internally, so different orgs can authenticate via different appsConfig format
Test plan
🤖 Generated with Claude Code