feat: generate snapshots on-demand when not cached#160
Draft
feat: generate snapshots on-demand when not cached#160
Conversation
The snapshot endpoint now triggers a clone and generates a snapshot in a single request rather than returning 404. If the repo mirror is not yet cloned, the request blocks until the clone completes before generating and serving the snapshot.
Replace scheduler-based serialization with a per-repo sync.Mutex. This prevents concurrent snapshot runs for the same repo without blocking on the scheduler's global worker pool, so on-demand HTTP requests are not delayed by unrelated repos' background jobs.
nssherpa
force-pushed
the
nsherpa/snapshot
branch
from
da30dc0 to
16fac5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /git/{host}/{path}/snapshot.tar.zst) previously returned 404 if no snapshot was cachedensureCloneReadyhelper handles theStateEmpty → clone → StateReadyandStateCloning → poll → StateReadytransitionsTest plan
TestSnapshotHTTPEndpoint— cache hit path unchanged; cache miss with no clonable repo returns 503TestSnapshotOnDemandGenerationViaHTTP— snapshot endpoint generates and serves a snapshot when none is cached but mirror is readyTestSnapshotGenerationViaLocalClone/TestSnapshotRemoteURLUsesServerURL— existing generation tests unaffectedWorks without cloning the repo first.