Add option to zero-initialize new elements created by resizeAndPreserve.#90
Open
aaronmswan wants to merge 1 commit intoblitzpp:mainfrom
Open
Add option to zero-initialize new elements created by resizeAndPreserve.#90aaronmswan wants to merge 1 commit intoblitzpp:mainfrom
aaronmswan wants to merge 1 commit intoblitzpp:mainfrom
Conversation
Member
|
Thank you! Also, thinking out loud, I'm wondering if we could make the API more general by e.g. making the new argument an element-type pointer: if ==null nothing happens, while non-null value gives the user the option to provide a non-zero value for initialisation? @citibeth - any comments? |
Contributor
|
Not sure what I think of it in the current context... This is the kind of change that could have unintended consequences. For example, what if someone wants to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found it useful to have new elements of an array created by resizeAndPreserve zero-initialize on request. For example when performing FFT interpolation. This can be a bit of a pain to do after the fact because multiple regions could need to be zeroed. I suppose this behavior could also be achieved externally to the library by re-implementing most of what resizeAndPreserve currently does.
Testing: passes "make check-testsuite".
Updated documentation.
Grateful for any feedback.