feat(register): [PM-27084] Account Register Uses New Data Types

[Patrick-Pimentel-Bitwarden]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27084

📔 Objective

1. Update register to use new data types
2. Added comments so that future removal of old properties is clear
3. Made accounts controller not permit nullish ambiguity
4. Added tests to demonstrate payloads result in same outcomes for the user model

📸 Screenshots

Screen.Recording.2025-12-11.at.5.21.28.PM.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

❌ Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.39%. Comparing base (3de2f98) to head (b33e1ac).

Files with missing lines	Patch %	Lines
...Api/Request/Accounts/RegisterFinishRequestModel.cs	0.00%	25 Missing ⚠️
src/Core/Utilities/KdfSettingsValidator.cs	0.00%	21 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #6715       +/-   ##
===========================================
- Coverage   53.86%   13.39%   -40.47%     
===========================================
  Files        1917     1146      -771     
  Lines       85126    49726    -35400     
  Branches     7620     3906     -3714     
===========================================
- Hits        45853     6661    -39192     
- Misses      37508    42943     +5435     
+ Partials     1765      122     -1643     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 9aa69ecf-68c3-481f-818e-ee82379b4402

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 427	details Method at line 427 of /src/Api/Auth/Controllers/AccountsController.cs gets a parameter from a user request from model. This parameter value flow... ID: VU8sgdorwW4N9vJXTUl%2BCpjmMcY%3D Attack Vector
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1519	details Method at line 1519 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... ID: dMGF5qNfAN72zlvQcA1MgbhHv%2Fc%3D Attack Vector
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1395	details Method at line 1395 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... ID: iOCFr11iI9znjDnv46yLfiS4aDY%3D Attack Vector

Fixed Issues (3)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 507
	CSRF	/src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 101
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 300

[Patrick-Pimentel-Bitwarden]

Adding @eligrubb to review because he has work he is branching off of this to do!

[claude]

Claude finished @Patrick-Pimentel-Bitwarden's task —— View job

---

Code Review Complete

Tasks

• Launch bitwarden-code-reviewer agent to analyze PR changes
• Complete review

---

Review Summary

The bitwarden-code-reviewer agent has completed a comprehensive analysis of PR #6715. The agent posted detailed inline comments directly on the PR covering security issues, backward compatibility concerns, test coverage, and code quality.

Key Findings:

• Security Concerns: Exception messages exposing implementation details, validation gaps
• Test Coverage: Missing tests for 3 out of 5 registration flows
• Backward Compatibility: Breaking changes in required properties need additional validation
• Code Quality: Null safety and validation improvements recommended

The agent's inline comments provide specific, actionable feedback with code suggestions. Please review the inline comments for detailed recommendations.

---