V2.1.1 - Wordlists changed to v3.0.0 wordlists#141
Draft
harvmaster wants to merge 2 commits intobitauth:masterfrom
Draft
V2.1.1 - Wordlists changed to v3.0.0 wordlists#141harvmaster wants to merge 2 commits intobitauth:masterfrom
harvmaster wants to merge 2 commits intobitauth:masterfrom
Conversation
|
Contributor
|
On the framework side, the |
e72ba49 to
60aec23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON mnemonic word lists in LibAuth V2.1 use
import someWordList from wordListFile assert { type: 'json' }which was an experimental JS feature. Recent versions of Rollup (which Vite uses) will no longer build with this syntax (causesunexpected tokenerror).This PR just updates the mnemonic word lists to the word list files used in V3.0.0 and updates the imports in
bip39.tsaccordingly.This creates a very large diff (for each of the word files). It might just be easier to run the below commands to copy over on top of what I have in this PR to ensure no changes to the word lists relative to V3.0.0.