Skip to content

Conversation

@mbuljan
Copy link

@mbuljan mbuljan commented Sep 18, 2015

I made a VERBOSE pre-processor symbol to Global.h that controls if ThreadPool class writes anything to console output.

Makefile now builds a shared object too and puts it in bin directory.

…oes the ThreadPool class write anything to console output. Also I altered a Makefile so that it also makes an .so file and puts it in bin directory
@mbuljan
Copy link
Author

mbuljan commented Sep 18, 2015

I would suggest you alter all your code so that it meets all requirements of the C++ google style guide, the naming in the project is terrible:
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html

Also I suggest you write unit tests for the project :) Do a lot of stress testing.

@mbuljan
Copy link
Author

mbuljan commented Sep 18, 2015

Here is a python script that takes .cpp and .h files as an argument and spits out all the style errors that dont corespont to google style guide:

https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py

you can make a build.sh script that runs this before compilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants