Open
Conversation
rjmunro
requested changes
Feb 17, 2026
packages/webui/src/client/ui/RundownView/RundownHeader/RundownHeaderTimers.tsx
Outdated
Show resolved
Hide resolved
packages/webui/src/client/ui/RundownView/RundownHeader/RundownHeaderTimers.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+46
to
+50
| className={classNames('timing__header_t-timers__timer', { | ||
| 'timing__header_t-timers__timer__countdown': timer.mode!.type === 'countdown', | ||
| 'timing__header_t-timers__timer__freeRun': timer.mode!.type === 'freeRun', | ||
| 'timing__header_t-timers__timer__isRunning': isRunning, | ||
| 'timing__header_t-timers__timer__isPaused': !isRunning, |
Collaborator
There was a problem hiding this comment.
Do you need the ! after mode? Can't Typescript infer it exists because you checked it on line 32?
Also can you do:
Suggested change
| className={classNames('timing__header_t-timers__timer', { | |
| 'timing__header_t-timers__timer__countdown': timer.mode!.type === 'countdown', | |
| 'timing__header_t-timers__timer__freeRun': timer.mode!.type === 'freeRun', | |
| 'timing__header_t-timers__timer__isRunning': isRunning, | |
| 'timing__header_t-timers__timer__isPaused': !isRunning, | |
| className={classNames('timing__header_t-timers__timer', | |
| 'timing__header_t-timers__timer__'+ timer.mode!.type | |
| 'timing__header_t-timers__timer__is' + isRunning ? 'Running' : 'Paused', | |
| { |
Collaborator
Author
There was a problem hiding this comment.
that's right, typescript detects it but after moving it out higher (to the rendering component) it doesn't anymore. As for the class concatenation, I would advise against it as it will make the classes un-ctrl+f-able across the codebase, and prone to unexpected breaks
Comment on lines
51
to
52
Collaborator
There was a problem hiding this comment.
These seem to be the same test - I assume the second one is supposed to be type countup or something.
packages/webui/src/client/ui/RundownView/RundownHeader/RundownHeaderTimers.tsx
Outdated
Show resolved
Hide resolved
packages/webui/src/client/ui/RundownView/RundownHeader/RundownHeaderTimers.tsx
Outdated
Show resolved
Hide resolved
anteeek
force-pushed
the
feat/t-timers-ui
branch
from
725115c to
e9fc4c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This PR is made on behalf of the BBC
Type of Contribution
This is a:
Feature
Current Behavior
Currently, there is no UI for t-timers
New Behavior
This PR adds UI for t-timers in playlist view
Testing
Affected areas
playlist view
Time Frame
Other Information
note: merge to feature branch
Status