Skip to content

fix: fallback to /usr/bin/env if env is not in PATH#3577

Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev:fix.env.without.path
Feb 8, 2026
Merged

fix: fallback to /usr/bin/env if env is not in PATH#3577
rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev:fix.env.without.path

Conversation

@rickeylev
Copy link
Collaborator

@rickeylev rickeylev commented Feb 8, 2026

This fixes an issue where the bootstrap script would fail if env was not in the PATH, which is the case on NixOS, or when Bazel's strict action env is enabled.

To fix, the bootstrap checks if env exists, and if not, falls back to /usr/bin/env.

Fixes #3575

This fixes an issue where the bootstrap script would fail if env was
not in the PATH, which is the case on NixOS. The script now checks if
env exists, and if not, falls back to /usr/bin/env.

Fixes bazel-contrib#3575
@rickeylev rickeylev requested a review from aignas as a code owner February 8, 2026 04:26
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compatibility issue in the Python bootstrap script, specifically for environments like NixOS where the env command might not be present in the system's PATH. By implementing a conditional check and a fallback to /usr/bin/env, the change enhances the script's robustness and portability, ensuring it can correctly execute Python interpreters regardless of the env command's direct availability.

Highlights

  • Robust env command usage: The bootstrap script now includes a check to determine if the env command is available in the system's PATH. If env is not found, the script will fall back to using the absolute path /usr/bin/env to ensure execution in environments where env might not be directly accessible, such as NixOS.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/private/stage1_bootstrap_template.sh
    • Added a conditional statement to check for the existence of the env command in the PATH.
    • Introduced an ENV_CMD variable that dynamically stores either 'env' or '/usr/bin/env' based on the check's outcome.
    • Modified the command array to use the ENV_CMD variable for executing the Python interpreter, ensuring the correct env utility is invoked.
Activity
  • No human activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where the bootstrap script could fail on systems like NixOS where env is not in the PATH. The change introduces a fallback to /usr/bin/env. My review includes a suggestion to make this fallback logic more robust by checking for the existence of /usr/bin/env and failing early with a clear error message if it's not available, which improves debuggability.

@rickeylev rickeylev enabled auto-merge February 8, 2026 04:34
@rickeylev rickeylev added this pull request to the merge queue Feb 8, 2026
Merged via the queue into bazel-contrib:main with commit dddd7a2 Feb 8, 2026
4 checks passed
@rickeylev rickeylev deleted the fix.env.without.path branch February 8, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run_binary() a py_binary() fails on a pure system (NixOS)

2 participants