fix: fallback to /usr/bin/env if env is not in PATH#3577
fix: fallback to /usr/bin/env if env is not in PATH#3577rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
This fixes an issue where the bootstrap script would fail if env was not in the PATH, which is the case on NixOS. The script now checks if env exists, and if not, falls back to /usr/bin/env. Fixes bazel-contrib#3575
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a compatibility issue in the Python bootstrap script, specifically for environments like NixOS where the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where the bootstrap script could fail on systems like NixOS where env is not in the PATH. The change introduces a fallback to /usr/bin/env. My review includes a suggestion to make this fallback logic more robust by checking for the existence of /usr/bin/env and failing early with a clear error message if it's not available, which improves debuggability.
This fixes an issue where the bootstrap script would fail if env was not in the PATH, which is the case on NixOS, or when Bazel's strict action env is enabled.
To fix, the bootstrap checks if env exists, and if not, falls back to /usr/bin/env.
Fixes #3575