Skip to content

chore(py_executable): print warning if build zip is enabled#3568

Open
rickeylev wants to merge 6 commits intobazel-contrib:mainfrom
rickeylev:pyzipapp.deprecation
Open

chore(py_executable): print warning if build zip is enabled#3568
rickeylev wants to merge 6 commits intobazel-contrib:mainfrom
rickeylev:pyzipapp.deprecation

Conversation

@rickeylev
Copy link
Collaborator

This prints a warning if --build_python_zip is enabled.

Work towards #3567 #2586

@rickeylev rickeylev requested a review from aignas as a code owner February 6, 2026 04:14
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a deprecation warning for the --build_python_zip flag within the py_executable rule. The change aims to inform users about the upcoming removal of this flag and guide them towards using the recommended py_zipapp_binary or py_zipapp_test rules instead, ensuring a smoother transition for projects relying on Python zip applications.

Highlights

  • Deprecation Warning: Introduced a warning message that is printed when the --build_python_zip flag is enabled. This flag is now deprecated and will be removed in a future release.
  • Migration Guidance: The warning advises users to switch to py_zipapp_binary or py_zipapp_test as alternatives to the deprecated --build_python_zip flag.
  • Issue Reference: The warning message includes a reference to GitHub issue Deprecate and remove implicit py_binary zipapp support #3567 for more context on the deprecation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/private/py_executable.bzl
    • Added a print statement within the _create_executable function to output a deprecation warning when build_zip_enabled is true.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helpful warning for the deprecated --build_python_zip flag, guiding users toward modern alternatives. The implementation is correct, and I've provided one minor suggestion to improve the code's style and readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants