feat(core): switch to script bootstrap as a default#3117
feat(core): switch to script bootstrap as a default#3117aignas wants to merge 7 commits intobazel-contrib:mainfrom
Conversation
aignas
force-pushed
the
check-script-default
branch
2 times, most recently
from
44578e9 to
55cb9c0
Compare
Work towards bazel-contrib#2156 Work towards bazel-contrib#2521 Relands bazel-contrib#2858 and reverts bazel-contrib#2968 Fixes bazel-contrib#2983
aignas
force-pushed
the
check-script-default
branch
from
55cb9c0 to
42dac20
Compare
|
FYI, @rickeylev, @alexeagle , we can continue talking about re-enabling the script=bootstrap by default for bazel 8+ here. Is there a good way to detect that we are running on that particular version with something else than |
PEPs can take a long time, so I don't think we should wait on that.
Maybe. If the 1.2 release is coming soon, then waiting sounds OK. If it takes too long, though, then I think we'll just have to press ahead. At the least, we should wait until there exists some rule that can package them. |
| The default for this depends on the platform and environment: | ||
| * Windows: `system_python` (**always** used) | ||
| * Non-Windows with Bazel 8 or higher: `script` | ||
| * Other: `system_python` |
There was a problem hiding this comment.
This is a bit of a mind puzzle 😅 . Might as well wait for 7 to drop and just do the simple windows -> system_python, posix -> script
There was a problem hiding this comment.
Yeah, I think with bazel 9 released we will do this.
3 participants
This PR enables the
bootstrapscript implementation for bazel 8 and abovefor UNIX platforms.
DO NOT MERGE: this has to be discussed:
Work towards #2156
Work towards #2521
Relands #2858 and reverts #2968
Fixes #2983
Related:
rules_pkgto produce working tars is in Support packaging raw symlinks from declare_symlink bazelbuild/rules_pkg#929 that has been released in 1.2.rules_imgappears to support symlinks: Symlinks in runfiles are not handled rules_img#254