fix: Conversation capture — catch any editNote error, fall through to create#24
Merged
phernandez merged 3 commits intomainfrom Feb 27, 2026
Merged
fix: Conversation capture — catch any editNote error, fall through to create#24phernandez merged 3 commits intomainfrom
phernandez merged 3 commits intomainfrom
Conversation
… create The previous code matched specific error types (isNoteNotFoundError) to decide whether to fall back to writeNote. The error format from callTool didn't match, so writeNote never fired — zero conversations captured. Fix: try append, if it fails for ANY reason, create the note. Also adds Conversation schema frontmatter (type: Conversation, date) to created notes. Fixes #22
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The indexConversation method now falls through to writeNote on any editNote error, not just not-found errors. Updated test to expect writeNote to be called on validation errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
The previous
indexConversationcode tried to match specific error types (isNoteNotFoundError) to decide whether to fall back towriteNote. The error format fromcallTooldidn't match the expected patterns, sowriteNotenever fired — zero conversations captured since alpha.13.Change
No error type matching. Append works? Great. Doesn't? Create.
Also adds proper Conversation schema frontmatter (
type: Conversation,date) to newly created notes.Once basic-memory#614 lands
This entire method becomes one line:
await this.editNote(title, 'append', entry)— BM handles create-on-miss.Fixes #22