fix: read schema definitions from file instead of stale database metadata#635
Open
fix: read schema definitions from file instead of stale database metadata#635
Conversation
…data schema-validate and schema-diff now read schema note frontmatter directly from the file via file_service, instead of relying on entity_metadata in the database. This ensures validation always uses the latest schema settings (validation mode, field declarations) even when the file watcher hasn't synced changes to the database. Falls back to database metadata if the file can't be read. Fixes #634 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Drew Cain <groksrc@gmail.com>
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7d2f35a2e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Validate that file frontmatter has required 'entity' and 'schema' fields before using it. If the file is mid-edit with incomplete metadata, fall back to database metadata to avoid 500 responses from parse_schema_note(). Addresses Codex review feedback on #635. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Drew Cain <groksrc@gmail.com>
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema-validate,schema-diff) now reads schema note frontmatter directly from the file instead of relying onentity_metadatain the databaseProblem
When users edit schema files externally (in their editor),
schema-validateused staleentity_metadatafrom the database. CLI commands (bm tool) don't start file watchers, so the database never gets updated until a manualbm reindex. Meanwhileread-notereads from the file and shows the correct data, making the stale validation results confusing.Changes
_schema_frontmatter_from_file()helper that reads and parses frontmatter viafile_servicevalidate_schemaanddiff_schema_endpointto use file-based schema resolutionFileServiceV2ExternalDepto both endpointstypefield is stable)Test plan
warn, file tostrict— validation correctly usesstrictfrom fileFixes #634
🤖 Generated with Claude Code