accept binary key for python2

[hamano]

We can't store binary key such as 0x80(0x79 is OK).
Is there any reason to restrict binary key?

test code

import riak
import binascii
client = riak.RiakClient(host="localhost")
bucket = client.bucket('test')
bucket.new(binascii.unhexlify('79'), data={'value':'79'}).store()
bucket.new(binascii.unhexlify('80'), data={'value':'80'}).store() # error
for key in bucket.get_keys():
    print binascii.hexlify(key), bucket.get(key).data

[lukebakken]

@javajolt - I assume there is a historical reason for this. Perhaps something to do with HTTP vs PB ?

[hazen]

@lukebakken There was a restriction historically for forcing the keys to be ASCII, before my time. It seems that Python2 is quite limited in its understanding of strings.

>>> binascii.unhexlify('79')
'y'
>>> binascii.unhexlify('80')
'\x80'

Once you start to get into the Unicode realm it escapes things. Python 3 just has binaries. My guess is that some of the HTTP string representations might not work with the \x notation. We could try the integration tests with non-ASCII keys and see what explodes...

[lukebakken]

@hamano - we can't accept this Pull Request without much, much more investigation. At this time yours is the only request to support this feature.

[hamano]

I've already seen basho/riak#415
HTTP Interface can not representat binary key, but I think It's unrelated to python client using PB.
Actually, other riak client(erlang client) allow to put binary key bucket, but I can't retrive it via python client.
Thank you.