Skip to content

Conversation

@vikions
Copy link

@vikions vikions commented Jan 14, 2026

Summary

This PR moves the op-rbuilder primitives out of the builder crate and into the shared base-primitives crate, as discussed in #370.

What changed

  • Moved op-rbuilder primitives from crates/builder/op-rbuilder/src/primitives into crates/shared/primitives/src/op_rbuilder
  • Updated builder code to import primitives from base_primitives::op_rbuilder
  • Removed the local primitives module from the builder crate
  • De-duplicated the Bundle type by relying on base-bundles
  • Gated telemetry setup behind the telemetry feature

Notes

  • No changes were made to base-bundles public APIs
  • cargo check -p op-rbuilder passes

Closes #370

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 14, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@refcell
Copy link
Contributor

refcell commented Jan 14, 2026

Hey @vikions could you rebase on the latest changes in main? Unfortunately this may be a bit of a pain since op-rbuilder crate is in heavy flux right now.

@vikions vikions force-pushed the chore/split-builder-primitives branch from f2fa699 to 114fb2c Compare January 14, 2026 04:29
@vikions
Copy link
Author

vikions commented Jan 14, 2026

Hey @vikions could you rebase on the latest changes in main? Unfortunately this may be a bit of a pain since op-rbuilder crate is in heavy flux right now.

Done 👍 Rebased onto latest main and resolved conflicts.

@haardikk21
Copy link
Collaborator

haardikk21 commented Jan 14, 2026

Hate to be that guy but there needs to be some significant rebases again. I would recommend waiting a day or so before attempting to rebase since there's some more heavy structural changes that need to happen before this

These changes should also simplify your PR significantly as a lot of unnecessary stuff is just getting deleted

@vikions
Copy link
Author

vikions commented Jan 14, 2026

Hate to be that guy but there needs to be some significant rebases again. I would recommend waiting a day or so before attempting to rebase since there's some more heavy structural changes that need to happen before this

These changes should also simplify your PR significantly as a lot of unnecessary stuff is just getting deleted

Sounds good — I’ll wait for the upcoming structural changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(builder): Split Out Builder Primitives

4 participants