chore(builder): remove standard builder mode #421
Merged
+715
−1,682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
haardikk21
requested review from
cody-wang-cb,
danyalprout,
meyer9,
niran and
refcell
haardikk21
commented
Jan 13, 2026
Collaborator
|
@haardikk21 this lgtm, can you give it a rebase and I'll approve first thing |
danyalprout
reviewed
Jan 14, 2026
| /// This trait is used to extend Reth's CLI with additional functionality that | ||
| /// are specific to the OP builder, such as populating default values for CLI arguments | ||
| /// when running in the playground mode or checking the builder mode. | ||
| /// when running in the playground mode. |
Comment on lines
+27
to
+40
| #[cfg(feature = "telemetry")] | ||
| let telemetry_args = match &cli.command { | ||
| reth_optimism_cli::commands::Commands::Node(node_command) => { | ||
| node_command.ext.telemetry.clone() | ||
| } | ||
| _ => Default::default(), | ||
| }; | ||
|
|
||
| #[cfg(not(feature = "telemetry"))] | ||
| let cli_app = cli.configure(); | ||
|
|
||
| #[cfg(feature = "telemetry")] | ||
| let mut cli_app = cli.configure(); | ||
| #[cfg(feature = "telemetry")] |
Comment on lines
+37
to
+41
| use super::payload::FlashblocksExecutionInfo; | ||
| use crate::{flashblocks::OpPayloadBuilderCtx, primitives::reth::ExecutionInfo, tx_signer::Signer}; | ||
|
|
||
| sol!( | ||
| // From https://github.com/Uniswap/flashblocks_number_contract/blob/main/src/FlashblockNumber.sol |
| }; | ||
|
|
||
| #[derive(Debug, Default, Clone)] | ||
| pub struct FlashblocksExtraCtx { |
Comment on lines
6
to
+21
| struct VariantInfo { | ||
| name: &'static str, | ||
| builder_type: &'static str, | ||
| default_instance_call: &'static str, | ||
| args_modifier: fn(&proc_macro2::TokenStream) -> proc_macro2::TokenStream, | ||
| default_args_factory: fn() -> proc_macro2::TokenStream, | ||
| } | ||
|
|
||
| const BUILDER_VARIANTS: &[VariantInfo] = &[ | ||
| VariantInfo { | ||
| name: "standard", | ||
| builder_type: "crate::builders::StandardBuilder", | ||
| default_instance_call: "crate::tests::LocalInstance::standard().await?", | ||
| args_modifier: |args| quote! { #args }, | ||
| default_args_factory: || quote! { Default::default() }, | ||
| }, | ||
| VariantInfo { | ||
| name: "flashblocks", | ||
| builder_type: "crate::builders::FlashblocksBuilder", | ||
| default_instance_call: "crate::tests::LocalInstance::flashblocks().await?", | ||
| args_modifier: |args| { | ||
| quote! { | ||
| { | ||
| let mut args = #args; | ||
| args.flashblocks.enabled = true; | ||
| args.flashblocks.flashblocks_port = crate::tests::get_available_port(); | ||
| args | ||
| } | ||
| const BUILDER_VARIANTS: &[VariantInfo] = &[VariantInfo { | ||
| name: "flashblocks", | ||
| default_instance_call: "crate::tests::LocalInstance::flashblocks().await?", | ||
| args_modifier: |args| { | ||
| quote! { | ||
| { | ||
| let mut args = #args; | ||
| args.flashblocks.flashblocks_port = crate::tests::get_available_port(); | ||
| args |
danyalprout
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #412
rb_testmacro to only test for Flashblocks--flashblocks.enabledCLI arg as it's considered always-on nowMost importantly, makes integrating FAL stuff into the builder way easier now that we dont have to worry about pleasing Rust's typesystem with the generic dance anymore