Skip to content

fix: update cache on validation #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cih9088 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: update cache on validation #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
871248e
fix: update cache on validation
cih9088 Jan 5, 2026
e8f96db
test: add ResponseStorer for 304
cih9088 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/validationresponsehandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ func (r *validationResponseHandler) HandleValidationResponse(
// RFC 9111 §4.3.3 Handling Validation Responses (304 Not Modified)
// RFC 9111 §4.3.4 Freshening Stored Responses upon Validation
updateStoredHeaders(ctx.Stored.Data, resp)
_ = r.rs.StoreResponse(req, ctx.Stored.Data, ctx.URLKey, ctx.Refs, ctx.Start, ctx.End, ctx.RefIndex)
CacheStatusRevalidated.ApplyTo(ctx.Stored.Data.Header)
r.l.LogCacheRevalidated(req, ctx.URLKey, ctx.ToMisc(nil))
return ctx.Stored.Data, nil
Expand Down
8 changes: 8 additions & 0 deletions internal/validationresponsehandler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ func Test_validationResponseHandler_HandleValidationResponse(t *testing.T) {
l: noopLogger,
},
setup: func(tt *testing.T, handler *validationResponseHandler) args {
handler.rs = &MockResponseStorer{
StoreResponseFunc: func(req *http.Request, resp *http.Response, key string, headers ResponseRefs, reqTime, respTime time.Time, refIndex int) error {
testutil.AssertEqual(tt, "key", key)
testutil.AssertTrue(tt, respTime.Equal(base))
testutil.AssertTrue(tt, reqTime.Equal(base))
return nil
},
}
return args{
req: &http.Request{Method: http.MethodGet},
resp: &http.Response{StatusCode: http.StatusNotModified, Header: http.Header{}},
Expand Down