Fix crash on Linux when testing the archive plugin#641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a rare crash in CI on the archive plugin.
The crash is a race condition in
PluginUtils.swift's execute method. The code set aterminationHandleron theProcessthat calledreadToEnd()on the pipe, while simultaneously thereadabilityHandlercould still be firing on the same pipe's file handle. On Linux (x86_64, Ubuntu 24.04 in CI), this race corrupts memory during Swift runtime metadata resolution (swift_conformsToProtocol, _swift_getGenericMetadata), which manifests as theSIGSEGVwe're seeing in_dispatch_event_loop_drain.The fix:
I removed the
terminationHandlerentirely. SincewaitUntilExit()is already called synchronously, we know the process is done.After
waitUntilExit(), we setreadabilityHandler = nilto stop the async reads, then do one finalreadToEnd()on the output queue to drain any remaining data.This eliminates the race between the readability handler and the termination handler competing over the same file handle.