Open
Conversation
|
@jamesiri Please pull this in! Thanks |
|
If I'm not wrong, the only thing was added is the PHP new versions parameter values so it doesn't mean "new php versions added". There should be new LaunchConfiguration resources for the new PHP versions. PR shouldn't be merge, otherwise it will break all the deployment if someone choose one of the "new versions" because there is no LaunchConfiguration for those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updated CF templates to use the latest instance types.
Updated the PHP versions to the ones that are currently supported by Wordpress
Fixed master template name and link on README.md
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.